[PATCH] readobj: Dump PE/COFF optional records.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Sat Jun 8 16:28:52 PDT 2013



================
Comment at: lib/Object/COFFObjectFile.cpp:467
@@ +466,3 @@
+      PE32Header = 0;
+      return;
+    }
----------------
You are not setting an error and returning early, this will leave the file in a inconsistent state (SectionTable is not set for example).

When is the pe header not present? It would be much nicer if we could have just one field named Header of type pe32_header.



http://llvm-reviews.chandlerc.com/D939



More information about the llvm-commits mailing list