[PATCH] ARM: fix CPS decoding

[Amaury de la Vieuville]

r183610!

On Sat, Jun 8, 2013 at 2:00 PM, Amaury de la Vieuville
<amaury.dlv at gmail.com> wrote:
> Hi Renato,
>
> Yes, these are all safe guards, I'll commit the patches then.
>
> Thanks!
> Amaury
>
> On Fri, Jun 7, 2013 at 10:53 PM, Renato Golin <renato.golin at linaro.org> wrote:
>> Hi Amaury,
>>
>> I'm not proficient with the disassembler, but by the look of your three
>> patches, it seems you're just filtering out bad encodings. Do they ever get
>> generated from LLVM? Or is this just a response to MC Hammer?
>>
>> If they ever get generated, would be good to know why and also fix the
>> origin, but if it's just safe guards, than I'm happy with all patches,
>> providing you double checked all encodings (I have to confess I did the
>> first, but not the others ;).
>>
>> cheers,
>> --renato
>>
>>
>> On 7 June 2013 15:47, Amaury de la Vieuville <Amaury.DeLaVieuville at arm.com>
>> wrote:
>>>
>>> Hi,
>>>
>>> This patch fixes the decoding of CPS in some cases where it is ambiguous
>>> with QADD.
>>> CPS is ambiguous with several other instructions, their decoders check
>>> for pred==0xf but do not check the rest of the encoding, we have to
>>> check for this in decodeCPSInstruction().
>>> This is usually done at the call site but I think in this case - as
>>> there are many of them - it is better to do that directly in the decode
>>> method of the instruction.
>>>
>>> Thanks,
>>> Amaury