[PATCH] [ELF] Refactor File.h.

[Rui Ueyama]

Shankar,

I tried not to change the behavior of the existing code when I was doing
this. I splitt the function and felt like it became easier to read, but I
still don't fully understand the logic of createAtom. Can I ask a few
questions?

- Looks like we create both LayoutBefore and LayoutAfter references. Do we
really need to create both? If A-layout-before-B is equivalent to
B-layout-after-A it doesn't look necessary.

- The constraints and the reason that weak symbols need to satisfy about
Reference are not very clear. Why are we handling weak symbols in such a
way and how these References are handled in the later passes?

On Wed, Jun 5, 2013 at 2:52 PM, Rui Ueyama <ruiu at google.com> wrote:

> Hi shankarke,
>
>  - Split createAtom() in lib/ReaderWriter/ELF/File.h into small methods.
>  - Added comments to code in other methods.
>
> No functionality changes.
>
> http://llvm-reviews.chandlerc.com/D921
>
> Files:
>   lib/ReaderWriter/ELF/File.h
>   test/elf/X86_64/weak-override.test
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130605/066bb49d/attachment.html>