[llvm] r183238 - ARM: Fix crash in ARM backend inside of ARMConstantIslandPass

[James Molloy]

Yep, agreed. I'd forgotten about the older MOVimm, which is stupid because
David even mentioned it earlier in the thread.

Brain-fail.

Cheers,

James

On 5 June 2013 13:35, Tim Northover <t.p.northover at gmail.com> wrote:

> > The architecture in the test case provided was armv4t, which does not
> have
> > MOVW/MOVT.
>
> It should have the older "MOV (imm)" instructions though, shouldn't
> it? They seem to support 8-bits in both ARM and Thumb.
>
> I'm not even that sure 8-bit loads *should* be supported. We're
> unlikely to allocate entries on an 8-bit granularity which means we
> can set the rest of the pool entry so that "ldr r0,[wherever]" would
> be just as effective and probably no more expensive than the ldrb.
>
> Not that I think it would be a bad thing necessarily, just probably
> pointless.
>
> Cheers.
>
> Tim
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130605/7d0e691d/attachment.html>