[PATCH] ARM FastISel integer sext/zext improvements

JF Bastien jfb at google.com
Tue Jun 4 18:06:09 PDT 2013


My recent ARM FastISel patch exposed this bug:
  http://llvm.org/bugs/show_bug.cgi?id=16178
The root cause is that it can't select integer sext/zext pre-ARMv6 and
asserts out.

The current integer sext/zext code doesn't handle other cases gracefully
either, so this patch makes it handle all sext and zext from i1/i8/i16 to
i8/i16/i32, with and without ARMv6, both in Thumb and ARM mode. This should
fix the bug as well as make FastISel faster because it bails to
SelectionDAG less often. See fastisel-ext.patch for this.

fastisel-ext-tests.patch changes current tests to always use reg-imm AND
for 8-bit zext instead of UXTB. This simplifies code since it is supported
on ARMv4t and later, and at least on A15 both should perform exactly the
same (both have exec 1 uop 1, type I).

2013-05-31-char-shift-crash.ll is a bitcode version of the above bug 16178
repro.

fast-isel-ext.ll tests all sext/zext combinations that ARM FastISel should
now handle.

Note that my ARM FastISel enabling patch was reverted due to a separate
failure when dealing with MCJIT, I'll fix this second failure and then turn
FastISel on again for non-iOS ARM targets.

I've tested "make check-all" on my x86 box, and "lnt test-suite" on A15
hardware.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130604/88187f8e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fastisel-ext.patch
Type: application/octet-stream
Size: 5934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130604/88187f8e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fastisel-ext-tests.patch
Type: application/octet-stream
Size: 5877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130604/88187f8e/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2013-05-31-char-shift-crash.ll
Type: application/octet-stream
Size: 641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130604/88187f8e/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fast-isel-ext.ll
Type: application/octet-stream
Size: 3111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130604/88187f8e/attachment-0003.obj>


More information about the llvm-commits mailing list