[llvm] r182991 - X86: change MOV64ri64i32 into MOV32ri64

Tim Northover t.p.northover at gmail.com
Sat Jun 1 02:56:06 PDT 2013


> This looks wrong. 0x88 isn't an AddReg opcode; 0x89, 0x8A, etc. are
> different opcodes:
>
> http://ref.x86asm.net/geek64.html#x88
>
> I'm seeing miscompiles in the JIT after this patch.

Bother, if only I'd read the list first this morning. Just spent an
hour or so coming to the same conclusion.

Thanks for reverting it Eric. I've reapplied the corrected version as r183068.



More information about the llvm-commits mailing list