[PATCH] [PECOFF][Writer] Implement the writer that can emit text section.

[Rui Ueyama]

================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:86
@@ +85,3 @@
+    _dosHeader.Magic = 0x5a4d;  // PE starts with the magic "MZ"
+    _dosHeader.AddressOfNewExeHeader = _size;
+  }
----------------
Shankar Kalpathi Easwaran wrote:
> dont you want to do a memset here too ?
I think I did at line 83.

================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:171
@@ +170,3 @@
+
+  llvm::object::pe32_header _peHeader;
+};
----------------
Shankar Kalpathi Easwaran wrote:
> why _public ?
Made this private.

================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:190
@@ +189,3 @@
+
+  llvm::object::data_directory _dirs[16];
+};
----------------
Shankar Kalpathi Easwaran wrote:
> again, why public ?
Made this protected.


http://llvm-reviews.chandlerc.com/D892