[PATCH] ARM: Add MC support for FSTMX & FLDMX

Amaury de la Vieuville Amaury.DeLaVieuville at arm.com
Fri May 31 08:40:19 PDT 2013


Hi Tim,

I removed the comments about sub targets which - correct me if I'm wrong
- are no longer relevant as VFPI and VFPXI set it to VFPv2 (which is
correct).
I also removed the NoItinerary.

Thanks,
Amaury

-----Original Message-----
From: Tim Northover [mailto:tnorthover at apple.com] 
Sent: 31 May 2013 14:53
To: Amaury de la Vieuville
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] ARM: Add MC support for FSTMX & FLDMX

Hi Amaury,

> This patch adds support for FSTMX & FLDMX.

A very odd corner case! Thanks for taking a look.

I think the bulk of the patch is good, but there are a couple of minor
issues:
+ There's a TODO about adding sub targets, this should be done if
necessary, and removed if not.
+ The itinerary parameters aren't really used. It would be a bit neater
to remove them entirely and hard-code NoItinerary.

Cheers.

Tim.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fstmx.diff
Type: application/octet-stream
Size: 8411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130531/a84e5e4d/attachment.obj>


More information about the llvm-commits mailing list