[PATCH] ARM: Fix VEXT encoding

[Amaury de la Vieuville]

Hi Tim,

Indeed, I meant 0b0xxx. Here is a new patch with your suggested change.

Thanks,
Amaury
________________________________________
From: Tim Northover [tnorthover at apple.com]
Sent: Friday, May 31, 2013 12:22 PM
To: Amaury de la Vieuville
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] ARM: Fix VEXT encoding

Hi Amaury,

> This patch enforces the following rule at the MC layer for the VEXT instruction:
>
> A8.8.316 VEXT
> if Q == '0' && imm4<3> == '1' then UNDEFINED;

Looks good to me with one modification: "index" is now only three bits so you should probably change its declaration to "bits<3> index". Just might stop someone scratching their head a bit later.

> When not used as a quadword operation, VEXT's imm4 operand must be of the form 0b1xxx.

Don't you mean 0b0xxx? If not, I may have misunderstood everything.

Tim.


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vext.diff
Type: text/x-patch
Size: 1651 bytes
Desc: vext.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130531/0a6a5c93/attachment.bin>