[PATCH] X86: tidy up MOV64ri64i32

[Evan Cheng]

Sent from my iPad

On May 30, 2013, at 9:32 AM, Tim Northover <tnorthover at apple.com> wrote:

> Hi,
> 
> This patch changes MOV64ri64i32 into something I've called MOV32ri64 to avoid the horrible MCInst lowering sub-register hackery. I've also taken the opportunity to implement one of the FIXMEs, combining label generation into a single selection pattern for this instruction.

The patch looks fine to me. 

> 
> The main thing I'm unsure of is whether I should have created it as a more detailed pseudo-instruction, with itineraries and so on to improve scheduling.

Yes please make sure it has proper itinerary entry. 

Thanks,

Evan

> 
> Does it look OK?
> 
> Cheers.
> 
> Tim.
> <0001-X86-change-MOV64ri64i32-into-MOV32ri64.patch>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits