[zorg] Add support for a new Aarch64 buildbot

Galina Kistanova gkistanova at gmail.com
Thu May 30 12:19:10 PDT 2013


Done.
r182955 and



On Thu, May 30, 2013 at 10:49 AM, Gabor Ballabas <gaborb at inf.u-szeged.hu>wrote:

>  Hello Galina,
>
> I am not familiar with the commit process so I would appreciate it if you
> could do that for me.
>
> Thanks for the review.
>
> Best regards,
> Gabor Ballabas
>
>
> On 05/30/13 19:27, Galina Kistanova wrote:
>
>  Looks good now.
> Please feel free to commit or let me know if you want me commit it for you.
>
> Thanks for working on this!
>
> Thanks
>
>  Galina
>
>
> On Wed, May 29, 2013 at 9:08 AM, Gabor Ballabas <gaborb at inf.u-szeged.hu>wrote:
>
>> Hello Galina,
>>
>> On 05/29/13 06:49, Galina Kistanova wrote:
>> > Hello Gabor,
>> >
>> > The patch looks Ok.
>> >
>> > There are two small things:
>> >
>> > > -    configure_args = ["./configure"]
>> > > +    configure_args = [WithProperties("%(builddir)s/" +
>> > "llvm/configure")]
>> > > +    # configure_args = [WithProperties("%s/" + "llvm/configure",
>> > "builddir")]
>> >
>> > Why do you need the commented line?
>> >
>>
>>  Oops! Obviously that line is not needed at all. I've removed it.
>>
>> > And for consistency with other builders, could you define llvm_srcdir
>> > (set it to "llvm" for in-tree or "llvm.src" for out-of-tree builds),
>> > and use it instead of hardcoded "llvm", please?
>>
>>  Done.
>>
>> I attached the final versions of both patches.
>> Thanks for your help.
>>
>> Best regards,
>> Gabor Ballabas
>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130530/47b8226d/attachment.html>


More information about the llvm-commits mailing list