[llvm] r182807 - Mips assembler: Improve set register alias handling

Jack Carter Jack.Carter at imgtec.com
Tue May 28 16:04:28 PDT 2013


Rafael,

The code is written by Vladimir and he sends it to us. We/I review it and sometimes it gets thrown back. In the end I am responsible for the patch and need to be in on whatever response is make anyway.

Mostly I will fix it up myself and submit it. We are many time zones away and this saves a lot of time.

I will add an email address in the comment message to make it easier to add CC lists.

Cheers,
Jack

________________________________________
From: Rafael EspĂ­ndola [rafael.espindola at gmail.com]
Sent: Tuesday, May 28, 2013 3:56 PM
To: Jack Carter
Cc: Vladimir Medic; llvm-commits; Chris Lattner
Subject: Re: [llvm] r182807 - Mips assembler: Improve set register alias handling

On 28 May 2013 18:52, Jack Carter <Jack.Carter at imgtec.com> wrote:
> Maybe not everyone is excited to have commit access.

Excited or not, this is part of our code review process:

http://llvm.org/docs/DeveloperPolicy.html#code-reviews

The patches are not being email for review before commit and being
committed by you makes the post commit review quiet a bit harder.

Cheers,
Rafael





More information about the llvm-commits mailing list