[PATCH] Tidy some register classes for ARM and Thumb

[JF Bastien]

Add -verify-machineinstrs to the Thumb tests that don't have it in
test/CodeGen/ARM/fast-isel*.





On Tue, May 28, 2013 at 11:30 AM, Eric Christopher <echristo at gmail.com>wrote:

> LGTM. Testcase for where this showed up?
>
> -eric
>
> On Tue, May 28, 2013 at 10:43 AM, JF Bastien <jfb at google.com> wrote:
> > Tidy up three places where the register class for ARM and Thumb wasn't
> > restrictive enough:
> >  - No PC dest for reg-reg add/orr/sub.
> >  - No PC dest for shifts.
> >  - No PC or SP for Thumb2 reg-imm add.
> >
> > I encountered this while combining FastISel with -verify-machineinstrs.
> > These instructions defined registers whose classes weren't restrictive
> > enough, and the uses failed verification. They're also undefined in the
> ISA,
> > or would produce code that FastISel wouldn't want. This doesn't fix the
> > register class narrowing issue (where uses should restrict definitions),
> and
> > isn't thorough, but it's a small step in the right direction.
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130528/4bf491ce/attachment.html>