[PATCH] Add colored diagnostics when building LLVM with cmake + ninja + clang

Arnaud A. de Grandmaison arnaud.adegm at gmail.com
Tue May 28 02:17:55 PDT 2013


When invoked from Ninja, clang does not detect that it can use colors : see 
https://github.com/martine/ninja/issues/174

This patch forces colored diagnostics when building LLVM with cmake + ninja + 
clang on UNIX (in CMake parlance) platforms only as I have not been able to 
test it on Windows.

I am wondering though if it could not break interactive tools relying on the 
compilation database, like Emacs or Vim, if they are not able to parse the 
color sequences. This does not seem to break clang_complete,and most tools are 
probably filtering the compilation command line anyway.

Thoughts ? OK to apply ?

Cheers,
-- 
Arnaud A. de Grandmaison
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-colored-diagnostics-when-building-LLVM-with-cmak.patch
Type: text/x-patch
Size: 1188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130528/5f4f32f7/attachment.bin>


More information about the llvm-commits mailing list