[PATCH] [nolibc] Add a test case for Linux/x86_64.

Alexey Samsonov samsonov at google.com
Mon May 27 23:42:12 PDT 2013


  I assume, you simply need this test to link w/o errors? Could you please add a comment describing your intent.


================
Comment at: lib/sanitizer_common/tests/CMakeLists.txt:94
@@ +93,3 @@
+                   DEPS ${SANITIZER_RUNTIME_LIBRARIES}
+                   ${SANITIZER_TEST_HEADERS})
+     add_compiler_rt_test(SanitizerUnitTests "Sanitizer-${arch}-Nolibc-Test"
----------------
Please use the following indentation:

  DEPS <dep1>
       <dep2>

================
Comment at: lib/sanitizer_common/tests/CMakeLists.txt:97
@@ +96,3 @@
+                          OBJECTS sanitizer_nolibc_test.${arch}.o
+                          -Wl,-whole-archive
+                          libRTSanitizerCommon.test.nolibc.${arch}.a
----------------
ditto


http://llvm-reviews.chandlerc.com/D873



More information about the llvm-commits mailing list