[PATCH] Fixed compiler-rt when outside projects directory

Alexey Samsonov samsonov at google.com
Mon May 27 02:36:15 PDT 2013


On Sat, May 25, 2013 at 1:07 AM, Greg Fitzgerald <garious at gmail.com> wrote:

> Thanks for the review.
>
>
> > You would need get_required_attr() here (as in other .cfg files)
>
> Done.  See updated patch attached.
>
>
> > Please submit this if it works for your configuration
>
> Can you either submit this on my behalf or give me commit access to
> compiler-rt?
>

Landed in r182726.


>
> Thanks,
> Greg
>
>
> On Fri, May 24, 2013 at 8:21 AM, Alexey Samsonov <samsonov at google.com>wrote:
>
>> LGTM (modulo one comment below). Please submit this if it works for your
>> configuration where compiler-rt is checked out in different place.
>> Thanks!
>>
>> -compiler_rt_lit_cfg = os.path.join(llvm_src_root, "projects",
>> "compiler-rt",
>> -                                   "lib", "lit.common.cfg")
>> +compiler_rt_src_root = getattr(config, 'compiler_rt_src_root', None)
>> +compiler_rt_lit_cfg = os.path.join(compiler_rt_src_root, "lib",
>> +                                   "lit.common.cfg")
>> You would need get_required_attr() here (as in other .cfg files) or check
>> that attr value is not None
>>
>>
>>
>>
>> On Fri, May 24, 2013 at 3:42 AM, Greg Fitzgerald <gregf at codeaurora.org>wrote:
>>
>>> Attached is a patch to fix the compiler-rt build when it is in a
>>> directory outside “llvm/projects”.  Can you please review?****
>>>
>>> ** **
>>>
>>> Thanks,****
>>>
>>> Greg****
>>>
>>> ** **
>>>
>>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
>>> by The Linux Foundation****
>>>
>>> ** **
>>>
>>
>>
>>
>> --
>> Alexey Samsonov, MSK
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>


-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130527/f3259fe2/attachment.html>


More information about the llvm-commits mailing list