[PATCH] [lsan] Add lit test support.

Sergey Matveev earthdok at google.com
Thu May 23 03:08:59 PDT 2013



================
Comment at: lib/lsan/lit_tests/lit.cfg:35
@@ +34,3 @@
+# Setup default compiler flags used with -fsanitize=leak option.
+clang_lsan_cxxflags = ("-ccc-cxx "
+                      + "-fsanitize=leak "
----------------
Alexey Samsonov wrote:
> I assume you can commit only when -fsanitize=leak is supported in Clang?
of course

================
Comment at: lib/lsan/lit_tests/lit.cfg:44
@@ +43,3 @@
+if llvm_tools_dir:
+  config.environment['LLVM_SYMBOLIZER_PATH'] = os.path.join(
+      llvm_tools_dir, "llvm-symbolizer")
----------------
Alexey Samsonov wrote:
> Env var name looks wrong
I'll just remove it for now, since I don't have any tests that require symbolization.

================
Comment at: lib/lsan/lit_tests/Unit/lit.cfg:21
@@ -20,3 +20,3 @@
 # Setup config name.
-config.name = 'LeakSanitizer'
+config.name = 'AddressSanitizer-Unit'
 
----------------
Alexey Samsonov wrote:
> Fix config.name
oops

================
Comment at: lib/lsan/CMakeLists.txt:48
@@ -47,2 +47,3 @@
 
 add_subdirectory(tests)
+add_subdirectory(lit_tests)
----------------
Alexey Samsonov wrote:
> While we're here, can you wrap this line in
> if (LLVM_INCLUDE_TESTS)
>   add_subdirectory(tests)
> endif()
done


http://llvm-reviews.chandlerc.com/D843



More information about the llvm-commits mailing list