[PATCH] Remove test instructions that proceed shift-by-immediate instructions

Manman Ren mren at apple.com
Tue May 21 15:53:32 PDT 2013


LGTM

Nitpick. Could you add comments in the source code about not optimizing away test instructions in some cases?

Thanks,
Manman

On May 19, 2013, at 1:32 AM, David Majnemer wrote:

> I've updated the patch.
> 
> This patch chooses not to optimize away test instructions if a lea instruction can be used to replace the left shift later.
> This seemed reasonable as it can give more flexibility in some cases but I'm not attached to the behavior of this either way.
> 
> 
> On Thu, May 16, 2013 at 4:57 AM, David Majnemer <david.majnemer at gmail.com> wrote:
> This is a follow-on to work done in r181937. It adds support for shift-by-immediate instructions. It appropriately deals with more obscure cases where the ZF flag isn't actually updated.
> 
> -- 
> David Majnemer
> 
> <shift-by-immediate-2.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130521/2771a7be/attachment.html>


More information about the llvm-commits mailing list