[lld] r182230 - [lld][ELF][x86_64, hexagon] Changed dynamic atoms to live in anonymous namespace

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue May 21 14:13:01 PDT 2013


On 21 May 2013 17:07, Shankar Easwaran <shankare at codeaurora.org> wrote:
> Its easier to manage include files rather than including all the
> functionality in one.
>
> Easier for reading / maintaining.

Sorry, but this file is include in only one *cpp* file. This is *very*
unusual for LLVM, which in turn causes the second oddness: an
anonymous namespace in a header file.

Please just inline HexagonDynamicAtoms.h into HexagonTargetHandler.cpp.


> Thanks
>
> Shankar Easwaran
>

Cheers,
Rafael



More information about the llvm-commits mailing list