[llvm-commits] [compiler-rt] r154583 - /compiler-rt/trunk/lib/Makefile.mk

[Daniel Dunbar]

I'm assuming Clang should be able to compile this file everywhere now
(seems to work fine for me in all the cases I tried), I am going to
reenable it in the build. Please let me know if you see a problem.

 - Daniel


On Tue, May 21, 2013 at 1:12 AM, Alexey Samsonov <samsonov at google.com>wrote:

> Hi Daniel!
>
> This was a fix after LLVM r154579 broke down compiler-rt build on our
> bot, clang failed to compile atomic.c after that revision.
> If this is fixed now, I'm ok with adding this file back to compiler-rt
> library.
>
> On Tue, May 21, 2013 at 1:31 AM, Daniel Dunbar <daniel at zuster.org> wrote:
>
>> Hi Alexey,
>>
>> Ancient history, I know, but can explain your motivation for this patch?
>>
>> I'm asking because this implicitly removes all knowledge of the atomic
>> functions from the Make based build system, so platform specific libraries
>> can't currently opt-in to including the atomic functionality.
>>
>> I can invent a new feature that allows the builtin module to exclude
>> certain functions from the "CommonFunctions" list, but I'd like to avoid
>> inventing that unless it is really necessary.
>>
>>  - Daniel
>>
>>
>>
>> On Thu, Apr 12, 2012 at 2:43 AM, Alexey Samsonov <samsonov at google.com>wrote:
>>
>>> Author: samsonov
>>> Date: Thu Apr 12 04:43:57 2012
>>> New Revision: 154583
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=154583&view=rev
>>> Log:
>>> Don't build atomic.c when building compiler-rt using make
>>>
>>> Modified:
>>>     compiler-rt/trunk/lib/Makefile.mk
>>>
>>> Modified: compiler-rt/trunk/lib/Makefile.mk
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/Makefile.mk?rev=154583&r1=154582&r2=154583&view=diff
>>>
>>> ==============================================================================
>>> --- compiler-rt/trunk/lib/Makefile.mk (original)
>>> +++ compiler-rt/trunk/lib/Makefile.mk Thu Apr 12 04:43:57 2012
>>> @@ -17,8 +17,13 @@
>>>  SubDirs += asan
>>>  SubDirs += profile
>>>
>>> +# FIXME: We don't currently support building an atomic library, and as
>>> it must
>>> +# be a separate library from the runtime library, we need to remove its
>>> source
>>> +# code from the source files list.
>>> +ExcludedSources := atomic.c
>>> +
>>>  # Define the variables for this specific directory.
>>> -Sources := $(foreach file,$(wildcard $(Dir)/*.c),$(notdir $(file)))
>>> +Sources := $(foreach file,$(wildcard $(Dir)/*.c),$(filter-out
>>> $(ExcludedSources),$(notdir $(file))))
>>>  ObjNames := $(Sources:%.c=%.o)
>>>  Implementation := Generic
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>
>
> --
> Alexey Samsonov, MSK
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130521/877b05ef/attachment.html>