[llvm] r182405 - Use std::list so that we have a stable iterator.

Rafael Espindola rafael.espindola at gmail.com
Tue May 21 11:53:51 PDT 2013


Author: rafael
Date: Tue May 21 13:53:50 2013
New Revision: 182405

URL: http://llvm.org/viewvc/llvm-project?rev=182405&view=rev
Log:
Use std::list so that we have a stable iterator.

I will try to avoid creating these std::strings, but for now this gets
the tests passing with libc++.

Modified:
    llvm/trunk/test/Object/obj2yaml.test
    llvm/trunk/tools/obj2yaml/coff2yaml.cpp

Modified: llvm/trunk/test/Object/obj2yaml.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/obj2yaml.test?rev=182405&r1=182404&r2=182405&view=diff
==============================================================================
--- llvm/trunk/test/Object/obj2yaml.test (original)
+++ llvm/trunk/test/Object/obj2yaml.test Tue May 21 13:53:50 2013
@@ -1,6 +1,5 @@
-RUN-disabled: obj2yaml %p/Inputs/trivial-object-test.coff-i386 | FileCheck %s --check-prefix COFF-I386
-RUN-disabled: obj2yaml %p/Inputs/trivial-object-test.coff-x86-64 | FileCheck %s --check-prefix COFF-X86-64
-RUN: true
+RUN: obj2yaml %p/Inputs/trivial-object-test.coff-i386 | FileCheck %s --check-prefix COFF-I386
+RUN: obj2yaml %p/Inputs/trivial-object-test.coff-x86-64 | FileCheck %s --check-prefix COFF-X86-64
 
 
 COFF-I386: header:

Modified: llvm/trunk/tools/obj2yaml/coff2yaml.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/obj2yaml/coff2yaml.cpp?rev=182405&r1=182404&r2=182405&view=diff
==============================================================================
--- llvm/trunk/tools/obj2yaml/coff2yaml.cpp (original)
+++ llvm/trunk/tools/obj2yaml/coff2yaml.cpp Tue May 21 13:53:50 2013
@@ -13,6 +13,8 @@
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/YAMLTraits.h"
 
+#include <list>
+
 using namespace llvm;
 
 namespace {
@@ -24,7 +26,7 @@ class COFFDumper {
   void dumpSections(unsigned numSections);
   void dumpSymbols(unsigned numSymbols);
   StringRef getHexString(ArrayRef<uint8_t> Data);
-  std::vector<std::string> Strings;
+  std::list<std::string> Strings;
 
 public:
   COFFDumper(const object::COFFObjectFile &Obj);





More information about the llvm-commits mailing list