[compiler-rt] r182303 - [nolibc] Move GetPageSize to the individual platforms.

Peter Collingbourne peter at pcc.me.uk
Tue May 21 02:37:14 PDT 2013


Hi Kostya,

On Tue, May 21, 2013 at 10:19:28AM +0400, Kostya Serebryany wrote:
> I've submitted 182351 to fix the build on Power.
> We may need to find another solution. Note that the page size is generally
> not a constant, even on x86.

Yes, that seems to be the case, now that I've read the glibc and
Linux kernel code more carefully.  I guess a sensible definition for
EXEC_PAGESIZE would be "the maximum possible page size" but this
clearly isn't the case on PPC.  This may be a bug in the kernel
headers.

For now I think it's fine to whitelist use of EXEC_PAGESIZE depending
on the architecture.

Thanks,
-- 
Peter



More information about the llvm-commits mailing list