[PATCH] [lsan] CMakeLists and lit test configs for LeakSanitizer.

Sergey Matveev earthdok at google.com
Mon May 20 03:37:49 PDT 2013



================
Comment at: lib/lsan/CMakeLists.txt:5
@@ +4,3 @@
+  ${SANITIZER_COMMON_CFLAGS}
+  -I${COMPILER_RT_SOURCE_DIR}/lib)
+
----------------
Alexey Samsonov wrote:
> I think include_directories(..) should do the trick. E.g. we don't have this -I flag in ASan CMake rules.
removed

================
Comment at: lib/lsan/CMakeLists.txt:15
@@ +14,3 @@
+
+set(LSAN_SRC_DIR ${COMPILER_RT_SOURCE_DIR}/lib/lsan)
+
----------------
Alexey Samsonov wrote:
> Use ${CMAKE_CURRENT_SOURCE_DIR} instead of hardcoded path.
done

================
Comment at: lib/lsan/CMakeLists.txt:25
@@ +24,3 @@
+  CFLAGS ${LSAN_CFLAGS}
+  DEFS ${LSAN_COMMON_DEFINITIONS})
+list(APPEND LSAN_RUNTIME_LIBRARIES clang_rt.lsan-${arch})
----------------
Alexey Samsonov wrote:
> You don't have any defs, remove this
done


http://llvm-reviews.chandlerc.com/D804



More information about the llvm-commits mailing list