[PATCH] Fix recent ARM remote-MCJIT regression

Tim Northover t.p.northover at gmail.com
Sun May 19 05:22:54 PDT 2013


Hi,

I've been looking at the recent failures on ARM MCJIT tests. There are
two issues:

1. Long-term known problems with how relocations are handled.
2. Regressions caused by recent faffing about with applyPermissions (probably).

I'm still working on the first problem, but meanwhile I think I've
spotted the cause of the second. lli's RemoteTarget calls
setExecutable after copying code across, but not any kind of cache
invalidation.

In fact, on Darwin platforms it seems to be setExecutable's
responsibility to invalidate the cache, so this patch does similarly
on other Unix-like systems.

I think this removes the need for a universal "don't do remote MCJIT
on ARM". It also seems to allow some individual tests to pass so I've
removed the XFAIL from them.

Ok to commit?

Cheers.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Invalidate-instruction-cache-when-setting-memory-to-.patch
Type: application/octet-stream
Size: 3944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130519/0c0b1cbf/attachment.obj>


More information about the llvm-commits mailing list