[lld] r182076 - [lld][ELF][X86_64] Reorganize X86_64 Target specific code

[Shankar Easwaran]

On 5/17/2013 3:42 PM, Sean Silva wrote:
> Unrelated to the patch, but can these be `static`?:
>
> +const uint8_t X86_64PLTAtom::_defaultContent[16] = {
> +  0xff, 0x25, 0x00, 0x00, 0x00, 0x00, // jmpq *gotatom(%rip)
> +  0x68, 0x00, 0x00, 0x00, 0x00,       // pushq reloc-index
> +  0xe9, 0x00, 0x00, 0x00, 0x00        // jmpq plt[-1]
> +};
>
> -- Sean Silva
>
Thanks for your reply, Sean.

These cannot be static, as these are entries for each PLT entry. Each 
PLT entry may have a different relocation index, thats pointing to the 
.rela.dyn entry.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation