[PATCH] [lsan] CMakeLists and lit test configs for LeakSanitizer.

Alexander Potapenko glider at google.com
Fri May 17 07:23:19 PDT 2013


  Drive-by comments. Better wait for Alexey for a thorough review.


================
Comment at: lib/lsan/tests/lit.site.cfg.in:9
@@ +8,3 @@
+  config.llvm_build_mode = config.llvm_build_mode % lit.params
+except KeyError,e:
+  key, = e.args
----------------
missing space between "," and "e"

================
Comment at: lib/lsan/tests/CMakeLists.txt:52
@@ +51,3 @@
+
+if(UNIX AND NOT APPLE
+    AND CAN_TARGET_x86_64
----------------
Which systems belong to "UNIX AND NOT APPLE"?

================
Comment at: lib/lsan/CMakeLists.txt:5
@@ +4,3 @@
+  ${SANITIZER_COMMON_CFLAGS}
+  -fPIC
+  -I${COMPILER_RT_SOURCE_DIR}/lib
----------------
Do you need -fPIC for your runtime?


http://llvm-reviews.chandlerc.com/D804



More information about the llvm-commits mailing list