[llvm] r182085 - Minor changes to the MCJITTest unittests to use the correct API for finalizing

David Tweed david.tweed at arm.com
Fri May 17 05:58:14 PDT 2013


Hi,

| The buildbot failure on the ARM pandaboard is due to an assertion failure:
| "Assertion `(*TargetPtr & 0x000F0FFF) == 0' failed." In the ARM
RuntimeDyld.

| This particular assertion is one I added last year as a sanity check that
| the relocation target address didn't already have an addend in it. Since
the
| object code may now be relocated before these are resolved, this
assumption
| may not be valid anymore.

| I don't removing this assertion should cause any problems.

Thanks for looking at this. (This slipped through because I tested on a
-Asserts build to minimise the time the hardware was out of use; won't do
that again...) I'm just running tests with that assertion removed, once
that's confirmed I'll commit the assertion removal.

This patch has also caused a regression on the MIPS buildbot; I suspect the
test is hitting MIPS equivalent of ARM's current inability to do multiple
relocations, but I'll give it a couple of days for any MIPS expert to look
at it before I disable the test on MIPS as well.

Cheers,
Dave








More information about the llvm-commits mailing list