[lld] r182033 - [lld] Do not create a temporary pair.

Chandler Carruth chandlerc at google.com
Thu May 16 12:26:12 PDT 2013


I have no particular opinion on this patch, but I do think that this type
of style change should probably at least be discussed prior to commit on
existing code... I just don't want to churn back and forth with stylistic
changes. Hopefully the discussion can be brief and clarify the desired
style patterns in the codebase.


On Thu, May 16, 2013 at 1:14 PM, Rui Ueyama <ruiu at google.com> wrote:

> I thought that the new code a bit cleaner because the repeated "->first"
> were removed and the type become obvious, but I'm open to changing it.
>
> llvm::tie wouldn't work because allocatedNew should change from false to
> true only. Once it becomes true it shouldn't become false again.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130516/1b247cfe/attachment.html>


More information about the llvm-commits mailing list