[PATCH] [LSan] Common leak checking module.

[Sergey Matveev]

================
Comment at: lib/lsan/lsan_common.h:121
@@ +120,3 @@
+
+  LeakReport *leak_report_;
+};
----------------
Alexander Potapenko wrote:
> Either name it "leak_report" without the trailing underscore, or make it private. Ditto for other callback classes.
According to the style guide, all class member variables must end with an underscore. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names

================
Comment at: lib/lsan/lsan_common.cc:53
@@ +52,3 @@
+
+void InitCommonLsan() {
+  InitializeFlags();
----------------
Alexander Potapenko wrote:
> Is this function used anywhere?
> Also, why "Common"?
It's called from the parent tool during initialization http://llvm-reviews.chandlerc.com/D762

> Also, why "Common"?

To avoid confusion with the standalone tool.


http://llvm-reviews.chandlerc.com/D787