[llvm] r181753 - This is the first of three patches which creates stubs used for

[reed kotler]

On 05/15/2013 11:58 AM, Rafael Espíndola wrote:
>> This APP/NO_APP would be covered in a separate patch and is only for
>> cosmetic purposes.
>>
>> I was not asking for the compiler to be able to tell this.
>>
>> I want be able to have a function attribute which tells asmprinter to not
>> emit those.
>> This could be usable by the compiler itself or if we *chose* to make it
>> general, by a user.
> NO. This is not ok. Anything that lets an IL pass or backend behave
> differently based on an inline asm being compiler generated or user
> generated is not ok.
>
Ok. I think I will let this issue pass. It's cosmetic in terms of .s and 
has no functional meaning
as regards the produced code.

>> This is not really that important but I think we should not have them here
>> because they serve no
>> purpose other than to make the stub harder to read.
> Not having to worry about semantics differences for user and compiler
> generated inline asm creeping into llvm is extremely important.
Ok.

>
> Cheers,
> Rafael