[llvm] r181895 - Remove MCELFObjectTargetWriter::adjustFixupOffset hack

[Rafael Espíndola]

Thanks!

On 15 May 2013 11:07, Ulrich Weigand <ulrich.weigand at de.ibm.com> wrote:
> Author: uweigand
> Date: Wed May 15 10:07:42 2013
> New Revision: 181895
>
> URL: http://llvm.org/viewvc/llvm-project?rev=181895&view=rev
> Log:
>
> Remove MCELFObjectTargetWriter::adjustFixupOffset hack
>
> Now that PowerPC no longer uses adjustFixupOffset, and no other
> back-end (ever?) did, we can remove the infrastructure itself
> (incidentally addressing a FIXME to that effect).
>
>
> Modified:
>     llvm/trunk/include/llvm/MC/MCELFObjectWriter.h
>     llvm/trunk/lib/MC/ELFObjectWriter.cpp
>     llvm/trunk/lib/MC/MCELFObjectTargetWriter.cpp
>
> Modified: llvm/trunk/include/llvm/MC/MCELFObjectWriter.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCELFObjectWriter.h?rev=181895&r1=181894&r2=181895&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/MC/MCELFObjectWriter.h (original)
> +++ llvm/trunk/include/llvm/MC/MCELFObjectWriter.h Wed May 15 10:07:42 2013
> @@ -94,8 +94,6 @@ public:
>    virtual const MCSymbol *undefinedExplicitRelSym(const MCValue &Target,
>                                                    const MCFixup &Fixup,
>                                                    bool IsPCRel) const;
> -  virtual void adjustFixupOffset(const MCFixup &Fixup,
> -                                 uint64_t &RelocOffset);
>
>    virtual void sortRelocs(const MCAssembler &Asm,
>                            std::vector<ELFRelocationEntry> &Relocs);
>
> Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=181895&r1=181894&r2=181895&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)
> +++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Wed May 15 10:07:42 2013
> @@ -759,9 +759,6 @@ void ELFObjectWriter::RecordRelocation(c
>    uint64_t RelocOffset = Layout.getFragmentOffset(Fragment) +
>      Fixup.getOffset();
>
> -  // FIXME: no tests cover this. Is adjustFixupOffset dead code?
> -  TargetObjectWriter->adjustFixupOffset(Fixup, RelocOffset);
> -
>    if (!hasRelocationAddend())
>      Addend = 0;
>
>
> Modified: llvm/trunk/lib/MC/MCELFObjectTargetWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCELFObjectTargetWriter.cpp?rev=181895&r1=181894&r2=181895&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/MCELFObjectTargetWriter.cpp (original)
> +++ llvm/trunk/lib/MC/MCELFObjectTargetWriter.cpp Wed May 15 10:07:42 2013
> @@ -39,10 +39,6 @@ const MCSymbol *MCELFObjectTargetWriter:
>    return &Symbol.AliasedSymbol();
>  }
>
> -void MCELFObjectTargetWriter::adjustFixupOffset(const MCFixup &Fixup,
> -                                                uint64_t &RelocOffset) {
> -}
> -
>  void
>  MCELFObjectTargetWriter::sortRelocs(const MCAssembler &Asm,
>                                      std::vector<ELFRelocationEntry> &Relocs) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits