[llvm] r181777 - [SystemZ] Add disassembler support

Chris Lattner clattner at apple.com
Tue May 14 17:54:42 PDT 2013


On May 14, 2013, at 3:17 AM, Richard Sandiford <rsandifo at linux.vnet.ibm.com> wrote:

> Author: rsandifo
> Date: Tue May 14 05:17:52 2013
> New Revision: 181777
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=181777&view=rev
> Log:
> [SystemZ] Add disassembler support

Very cool, but:

> +++ llvm/trunk/test/MC/Disassembler/SystemZ/insn-a.txt Tue May 14 05:17:52 2013
> @@ -0,0 +1,21 @@
> +# RUN: llvm-mc --disassemble %s -triple=s390x-linux-gnu | FileCheck %s
> +# CHECK: a %r0, 0
> +0x5a 0x00 0x00 0x00
> +
> +# CHECK: a %r0, 4095
> +0x5a 0x00 0x0f 0xff
> +
> +# CHECK: a %r0, 0(%r1)
> +0x5a 0x00 0x10 0x00
> +
> +# CHECK: a %r0, 0(%r15)
> +0x5a 0x00 0xf0 0x00
> +
> +# CHECK: a %r0, 4095(%r1,%r15)
> +0x5a 0x01 0xff 0xff
> +
> +# CHECK: a %r0, 4095(%r15,%r1)
> +0x5a 0x0f 0x1f 0xff
> +
> +# CHECK: a %r15, 0
> +0x5a 0xf0 0x00 0x00
> 

Please consolidate these tests into fewer larger tests.  There is no hard and fast rule here, but one major advantage of FileCheck is that it lets you have larger tests without reducing precision.  Having tests that are too fined-grained increases testing time and makes the source tree messier.

-Chris




More information about the llvm-commits mailing list