[PATCH] [lld][LayoutPass] Split buildFollowOnTable for readability.

Shankar Kalpathi Easwaran shankarke at gmail.com
Mon May 13 17:33:55 PDT 2013


  with the formatting, code LGTM.


================
Comment at: lib/Passes/LayoutPass.cpp:391-393
@@ -420,4 +390,5 @@
     if (start != _followOnRoots.end()) {
-      for (const DefinedAtom *nextAtom = start->second; nextAtom != NULL;
+      for (const DefinedAtom *nextAtom = start->second;
+           nextAtom;
            nextAtom = _followOnNexts[nextAtom]) {
         AtomToOrdinalT::iterator pos = _ordinalOverrideMap.find(nextAtom);
----------------
Rui Ueyama wrote:
> Shankar Kalpathi Easwaran wrote:
> > you might want to run the changes with clang-format, if it has not been done already. 
> This would become a pretty large change if I run clang-format, so I won't do that at least in this patch. We might want to do that in another patch.
You can reduce the context to the diffs. Pass the -U0 option to diff.

svn diff --diff-cmd diff -x -U0 | ~/work/llvm/clang-format-diff.py -p0




http://llvm-reviews.chandlerc.com/D790



More information about the llvm-commits mailing list