[PATCH][RFC] Add 'CHECK-<N>' directive in FileCheck

[Jakob Stoklund Olesen]

On Apr 29, 2013, at 12:06 PM, Michael Liao <michael.liao at intel.com> wrote:

> As the usage of 'grep' in regression tests is deprecated [1], the
> attached patch proposes adding 'CHECK-<N>' to cover one usage of 'grep',
> i.e. 'grep <pat> | count <N>' which check there are exactly <N>
> occurrences of <pat> in the input string.

Hi Michael,

This doesn’t really make sense to me. A CHECK-<N> line in a FileCheck test case isn’t any better than 'grep | count N'.

We want test cases to be rewritten as FileCheck tests so they can be more specific about what they’re testing. I don’t think there is any value to converting a 'grep | count N’ test to FileCheck if it isn’t expanded to something meaningful at the same time.

/jakob