[PATCH] tidy the MCJIT tests now applyPermissions will invalidate cache

Filip Pizlo fpizlo at apple.com
Mon May 13 08:37:54 PDT 2013


Wouldn't it be better if the tests did the "right thing" and called TheJIT->finalizeObject()?

I'm not sure how much I like SectionMemoryManager::applyPermissions() being specified to also mean flushing cache, but I don't have a strong opinion on that.

-Filip


On May 13, 2013, at 3:44 AM, David Tweed <david.tweed at arm.com> wrote:

> Hi,
> 
> please find attached a minor clean-up patch for the MCJIT tests (along with
> adding some explicit commentary to the applyPermissions()'s declarations).
> Please review and if this is acceptable I'll commit to the codebase.
> 
> Cheers,
> Dave<mcjit.diff>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130513/3992fbce/attachment.html>


More information about the llvm-commits mailing list