[llvm] r181663 - StringRefize some debug accel table bits.

Eric Christopher echristo at gmail.com
Sat May 11 11:32:02 PDT 2013


Thanks :)

-eric

On Sat, May 11, 2013 at 11:24 AM, Benjamin Kramer
<benny.kra at googlemail.com> wrote:
> Author: d0k
> Date: Sat May 11 13:24:28 2013
> New Revision: 181663
>
> URL: http://llvm.org/viewvc/llvm-project?rev=181663&view=rev
> Log:
> StringRefize some debug accel table bits.
>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.h
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp?rev=181663&r1=181662&r2=181663&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp Sat May 11 13:24:28 2013
> @@ -76,7 +76,7 @@ static bool compareDIEs(const DwarfAccel
>    return A->Die->getOffset() < B->Die->getOffset();
>  }
>
> -void DwarfAccelTable::FinalizeTable(AsmPrinter *Asm, const char *Prefix) {
> +void DwarfAccelTable::FinalizeTable(AsmPrinter *Asm, StringRef Prefix) {
>    // Create the individual hash data outputs.
>    for (StringMap<DataArray>::iterator
>           EI = Entries.begin(), EE = Entries.end(); EI != EE; ++EI) {
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.h?rev=181663&r1=181662&r2=181663&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.h (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.h Sat May 11 13:24:28 2013
> @@ -271,7 +271,7 @@ private:
>    DwarfAccelTable(ArrayRef<DwarfAccelTable::Atom>);
>    ~DwarfAccelTable();
>    void AddName(StringRef, DIE*, char = 0);
> -  void FinalizeTable(AsmPrinter *, const char *);
> +  void FinalizeTable(AsmPrinter *, StringRef);
>    void Emit(AsmPrinter *, MCSymbol *, DwarfUnits *);
>  #ifndef NDEBUG
>    void print(raw_ostream &O);
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=181663&r1=181662&r2=181663&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Sat May 11 13:24:28 2013
> @@ -2066,7 +2066,7 @@ void DwarfDebug::emitAccelNames() {
>      const StringMap<std::vector<DIE*> > &Names = TheCU->getAccelNames();
>      for (StringMap<std::vector<DIE*> >::const_iterator
>             GI = Names.begin(), GE = Names.end(); GI != GE; ++GI) {
> -      const char *Name = GI->getKeyData();
> +      StringRef Name = GI->getKey();
>        const std::vector<DIE *> &Entities = GI->second;
>        for (std::vector<DIE *>::const_iterator DI = Entities.begin(),
>               DE = Entities.end(); DI != DE; ++DI)
> @@ -2095,7 +2095,7 @@ void DwarfDebug::emitAccelObjC() {
>      const StringMap<std::vector<DIE*> > &Names = TheCU->getAccelObjC();
>      for (StringMap<std::vector<DIE*> >::const_iterator
>             GI = Names.begin(), GE = Names.end(); GI != GE; ++GI) {
> -      const char *Name = GI->getKeyData();
> +      StringRef Name = GI->getKey();
>        const std::vector<DIE *> &Entities = GI->second;
>        for (std::vector<DIE *>::const_iterator DI = Entities.begin(),
>               DE = Entities.end(); DI != DE; ++DI)
> @@ -2123,7 +2123,7 @@ void DwarfDebug::emitAccelNamespaces() {
>      const StringMap<std::vector<DIE*> > &Names = TheCU->getAccelNamespace();
>      for (StringMap<std::vector<DIE*> >::const_iterator
>             GI = Names.begin(), GE = Names.end(); GI != GE; ++GI) {
> -      const char *Name = GI->getKeyData();
> +      StringRef Name = GI->getKey();
>        const std::vector<DIE *> &Entities = GI->second;
>        for (std::vector<DIE *>::const_iterator DI = Entities.begin(),
>               DE = Entities.end(); DI != DE; ++DI)
> @@ -2158,7 +2158,7 @@ void DwarfDebug::emitAccelTypes() {
>        = TheCU->getAccelTypes();
>      for (StringMap<std::vector<std::pair<DIE*, unsigned> > >::const_iterator
>             GI = Names.begin(), GE = Names.end(); GI != GE; ++GI) {
> -      const char *Name = GI->getKeyData();
> +      StringRef Name = GI->getKey();
>        const std::vector<std::pair<DIE *, unsigned> > &Entities = GI->second;
>        for (std::vector<std::pair<DIE *, unsigned> >::const_iterator DI
>               = Entities.begin(), DE = Entities.end(); DI !=DE; ++DI)
> @@ -2222,7 +2222,7 @@ void DwarfDebug::emitDebugPubnames() {
>
>        if (Asm->isVerbose())
>          Asm->OutStreamer.AddComment("External Name");
> -      Asm->OutStreamer.EmitBytes(StringRef(Name, strlen(Name)+1), 0);
> +      Asm->OutStreamer.EmitBytes(StringRef(Name, GI->getKeyLength()+1), 0);
>      }
>
>      Asm->OutStreamer.AddComment("End Mark");
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list