[PATCH] [sanitizer] Move GetStackTrace from ASan to sanitizer_common.

Kostya Serebryany kcc at google.com
Wed May 8 04:52:39 PDT 2013



================
Comment at: lib/asan/asan_stack.h:45
@@ +44,3 @@
+    } else {                                                    \
+      stack_top = stack_bottom = 0;                             \
+    }                                                           \
----------------
initialize these in the declaration and drop the else clause

================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.cc:266
@@ -265,1 +265,3 @@
 
+#if SANITIZER_LINUX || SANITIZER_MAC
+void GetStackTrace(StackTrace *stack, uptr max_s, uptr pc, uptr bp,
----------------
why not in sanitizer_common/sanitizer_posix.cc ? 


http://llvm-reviews.chandlerc.com/D766



More information about the llvm-commits mailing list