[llvm] r181066 - Delete test instead.

[David Blaikie]

On Fri, May 3, 2013 at 4:09 PM, Amara Emerson <amara.emerson at gmail.com> wrote:
> Hi Bill,
>
> This seems to be due to some compiler dependent failures which I'm currently
> investigating. I just removed it to prevent polluting the buildbots further,
> it'll be re-committed with the fix, otherwise I'll revert the original
> feature commit.

Usually we do this by XFAILing the test rather than deleting it.

(also, even that's a questionable practice - if you just committed
something that broke the bots, the strategy should be to revert your
patch until you understand why it's broken (be it a test bug or a
production bug))

>
> Regards,
> Amara
>
>
> On 3 May 2013 23:58, Bill Wendling <wendling at apple.com> wrote:
>>
>> On May 3, 2013, at 3:39 PM, Amara Emerson <amara.emerson at arm.com> wrote:
>>
>> > Author: aemerson
>> > Date: Fri May  3 17:39:03 2013
>> > New Revision: 181066
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=181066&view=rev
>> > Log:
>> > Delete test instead.
>> >
>> Hi Amara,
>>
>> Does this test point to a real problem? or is it just not a good test? If
>> the former, you should keep this test around and fix the problem. :-)
>>
>> -bw
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>