[patch] Enabling EH in MCJIT

[Kaylor, Andrew]

The distinction is that loadObject allocates new memory for the sections and gets things in place, but the client can still move sections around (including copying sections to an external process or remote system) and reapply relocations.  The finalizeObject call is made when the client is ready for things to be executed where they are, so putting the registerEHFrames call in finalizeObject is correct.

Can you add a comment in the RuntimeDyldMemoryManager declaration of registerEHFrames saying that the default implementation does nothing and maybe referring to SectionMemoryManager as a reference implementation?

Is the __register_frame function present on ARM with MachO?  If so, then I think this patch looks ready to go.  If not, obviously you need something there.

Thanks,
Andy

-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: Friday, May 03, 2013 8:37 AM
To: Kaylor, Andrew
Cc: llvm-commits
Subject: Re: [patch] Enabling EH in MCJIT

>> I've read through this quickly, but I haven't had time for a careful review yet.  On first pass, it looks pretty good.  Thanks for returning to this issue!

Oh, one thing I forgot to mention is that it is not clear to me what should go in loadObject and what should go in finalizeObject. Is the EH registration in the right function?

Cheers,
Rafael