[Patch] Fix stack alignment for calls without frame setup or destroy

Andrew Turner andrew at fubar.geek.nz
Fri May 3 03:55:34 PDT 2013


On Mon, 22 Apr 2013 11:22:59 +0100
Renato Golin <renato.golin at linaro.org> wrote:

> Hi Andrew,
> 
> Sorry for the delay. I had a read on the code around it and it seems
> that with your patch, the stack will always grow if there is a call
> and not a frame pointer. I'm not sure how this correlates with
> functions without stack setup, line __aeabi_read_tp, but it might
> bloat the stack for many other unrelated functions.
> 
> However, I can see from the comments that adjusting the stack should
> be done on any function call, and I don't know that part of the code
> well enough, so if no one else has any objections, I'm ok with your
> patch.

Is someone able to commit this patch?

Andrew



More information about the llvm-commits mailing list