[PATCH] ARM build attributes support

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed May 1 05:29:35 PDT 2013


On 1 May 2013 03:42, Amara Emerson <amara.emerson at arm.com> wrote:
> Thanks for taking a look at this Rafael.
>
> The ARMGenericBuildAttrInfo is just there for convenience, partly because attributes do not necessarily have integer types, but can be strings as well. I thought accessing the attributes symbolically would be a bit cleaner as well, but I don't have a strong preference for this method.

I guess I would still prefer having the value be a union, but the
current implementation is fine if you expect the attribute list to be
fairly stable.

Can you just get someone at ARM to double check the attributes themselves?

> Yes, ARMBuildAttrs.h should be removed, I forgot to include that in the diff when I updated the old patch.

Cool. LGTM with that.

Cheers,
Rafael




More information about the llvm-commits mailing list