[PATH] [x86_64] Minor tweak to VMOVPQIto64rr instruction definition

Magee, Joshua Joshua_Magee at playstation.sony.com
Tue Apr 30 19:59:06 PDT 2013


Hi,

In our private tree we had a change to fix the assembly string for the
VMOVPQIto64rr instruction (it lacked the 'v' prefix).  This was fixed in the
public tree at svn r162963 by adding a 'v' to the assembly string.  Our private
fix was a bit different: I changed the instruction class from the basic 'I'
class to the more specialized 'VRPDI' class.

While both fixes are functionally equivalent, I think my fix of using VRPDI is
more consistent with many other related instruction definitions.

Looking back through the version history, VMOVPQIto64rr previously used the VRPDI
instruction class until r140098.  That commit fixed PR10949 by using a generic
instruction class and then explicitly listing all the required flags (VEX,
VEX_W, etc).  While that worked, it was overkill; all that was needed was to
add the VEX flag to the instruction.


Attached is a patch against TOT which uses VRPDI.  It is functionally
equivalent to the current code but more consistent with the way other related
instructions are defined.

This is a very minor issue, but I had the patch anyway so I figured I might as well
mention it.

Thanks,
Josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmovd.patch
Type: application/octet-stream
Size: 1908 bytes
Desc: vmovd.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130501/0ad059e1/attachment.obj>


More information about the llvm-commits mailing list