[PATCH] [mc-coff] Forward Linker Option flags into the .drectve section

Reid Kleckner rnk at google.com
Tue Apr 30 09:18:11 PDT 2013


On Tue, Apr 30, 2013 at 12:40 AM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
> Hi Reid,
>
>> I was working under the assumption that this pragma would only be used
>> for COFF and that the linker would understand /defaultlib, since
>> presumably it already has to understand /export to implement
>> __declspec(dllexport).
> This is wrong assumption. ld also supports .drectve section. However,
> it uses "-export" instead of "/export".
>
> Having generic linker option metadata looks nice, however, here it
> seems we better need to model depending libs metadata explicitly.

The conclusion from Daniel's email seemed to be that we should leave
the linker options metadata alone and choose the right flag for this
option in some target-dependent part of clang.  We could change that
to use a dependent libs schema, but we'd have to go back to the
original RFC and reconsider things like how to represent static vs
dynamic and ordering.

So, I don't think there's anything wrong with the LLVM commit, but
feel free to review the clang patch I sent, which has no comments yet.
 :)  There are other things I'd like feedback on like the previously
mentioned PPCallbacks vs. ASTConsumer bit.



More information about the llvm-commits mailing list