[llvm] r180730 - Disable the MCJIT tests on 32 bit darwin.

[Charles Davis]

Hi Don,

On Apr 29, 2013, at 3:47 PM, Don Crandall wrote:

> Hi Chip,
> 
> I would be interested in the patch you just referred to. Any tips as to how I can find it?
Like I said, it's buried somewhere in LLDB's Subversion repo. I don't recall what revision, but you're looking for a file matching the glob "llvm-*.patch" in the "scripts" directory that contains changes to the RuntimeDyld and/or MCJIT libraries. Unfortunately, the Subversion command-line client doesn't provide any good way (that I know of; that might have changed in 1.7) to see what files were changed by each revision. (Git, of course, does not have this problem. :)
> Trying to find tips on relocations for Darwin PPC for the PPCMachObjectWriter.cpp that I'd like to improve upon.
I don't think that patch file will help you much. It only implemented i386 scattered relocations, because Apple doesn't use PowerPC Macs anymore; therefore (as far as they're concerned) no one uses them anymore ;). (I'm just messing with ya. I know you and David Fang at least are interested in Darwin/PPC. Just don't expect any sympathy from Apple.) Anyway, it might give you some clues about scattered relocations in general, but that's about it.

Chip

> 
> Thanks,
> Don
> 
> On 4/29/13 2:17 PM, Charles Davis wrote:
>> On Apr 29, 2013, at 3:09 PM, Rafael Espindola wrote:
>> 
>>> Author: rafael
>>> Date: Mon Apr 29 16:09:32 2013
>>> New Revision: 180730
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=180730&view=rev
>>> Log:
>>> Disable the MCJIT tests on 32 bit darwin.
>>> 
>>> I recently enabled them on 32 and 64 bit darwin, but it looks like 32 bit is
>>> still fairly broken.
>> As I recall, MCJIT and/or RuntimeDyld need support for scattered relocations before this will work on Darwin/i386. LLDB used to have a patch for this, but they seem to have dropped it. (The patch, which is still somewhere in version control, is probably way out of date anyway.)
>> 
>> Chip
>> 
>>> Modified:
>>>    llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
>>> 
>>> Modified: llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg?rev=180730&r1=180729&r2=180730&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg (original)
>>> +++ llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg Mon Apr 29 16:09:32 2013
>>> @@ -17,5 +17,8 @@ else:
>>> if root.host_arch not in ['i386', 'x86', 'x86_64', 'ARM', 'Mips', 'PowerPC']:
>>>     config.unsupported = True
>>> 
>>> +if 'i386-apple-darwin'  in root.target_triple:
>>> +    config.unsupported = True
>>> +
>>> if 'powerpc' in root.target_triple and not 'powerpc64' in root.target_triple:
>>>     config.unsupported = True
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>