[llvm] r180716 - Propagate relocation info to resolveRelocation.

[Kaylor, Andrew]

I don't have a big preference either way, just so we're consistent.  It looks like everything is either public or protected in RuntimeDyldMachO, so making this protected in RuntimeDyldELF is probably the path of least resistance.

-Andy

-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: Monday, April 29, 2013 12:07 PM
To: Kaylor, Andrew
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r180716 - Propagate relocation info to resolveRelocation.

On 29 April 2013 15:00, Kaylor, Andrew <andrew.kaylor at intel.com> wrote:
> No, I just like things to be explicit.
>
> I'm not aware of anything that derives from RuntimeDyldELF at the moment, though it might make sense to refactor it to divide the various architectures into subclasses.  I don't think there's been much thought given to dividing private and protected in that class.  Making just that one function private gives the impression that the other stuff really should be protected, which isn't necessarily true.

I see. I can make it protected or make everything else private. What is your preference?

> -Andy
>

Cheers,
Rafael