[PATCH] Add support to FileCheck for out-of-order matching

Michael Liao michael.liao at intel.com
Mon Apr 29 13:58:05 PDT 2013


Please check the attached patches for CHECK-DAG support with CHECK-NOT
mixed. Attachment has 2 parts:

* 0001-Refactor-string-checking.patch is the code refactoring of string
checking. It's the same one as I attached in [1]

* 0002-Add-CHECK-DAG-support.patch adds CHECK-DAG support as well as
test cases and documents.

Thanks
- Michael

--
[1]
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130429/173068.html

On Wed, 2013-04-24 at 15:01 -0700, Jakob Stoklund Olesen wrote:
> On Apr 24, 2013, at 2:44 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> 
> > ----- Original Message -----
> >> From: "Jakob Stoklund Olesen" <stoklund at 2pi.dk>
> >> To: "Michael Liao" <michael.liao at intel.com>
> >> Cc: "Eli Bendersky" <eliben at google.com>, "Hal Finkel" <hfinkel at anl.gov>, "llvm-commits" <llvm-commits at cs.uiuc.edu>
> >> Sent: Wednesday, April 24, 2013 4:25:02 PM
> >> Subject: Re: [PATCH] Add support to FileCheck for out-of-order matching
> >> 
> >> 
> >> On Apr 24, 2013, at 11:35 AM, Michael Liao <michael.liao at intel.com>
> >> wrote:
> >> 
> >>> Is it valueable to mix CHECK-NOT and CHECK-DAG together?
> >> 
> >> Hal, do you have any use cases where it would be useful to mix
> >> CHECK-DAG and CHECK-NOT?
> > 
> > Not currently; if I have CHECK-DAG then I can affirmatively check for the instructions that I expect (regardless of order), and I can't think of a case where I'd mix that with CHECK-NOT.
> 
> In that case, I think we should go with the simplest possible semantics when mixing CHECK-DAG and CHECK-NOT.
> 
> To me, that is having CHECK-NOT act as a barrier, just like CHECK does. CHECK-DAGs don't reorder across a CHECK-NOT.
> 
> Thanks,
> /jakob
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-string-checking.patch
Type: text/x-patch
Size: 7776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130429/fb416569/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-CHECK-DAG-support.patch
Type: text/x-patch
Size: 18198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130429/fb416569/attachment-0001.bin>


More information about the llvm-commits mailing list