[Patch][Review Request][llvm-link] Fix One Performance Bug

[Du Toit, Stefanus]

On 2013-04-29 10:46 AM, "Wan, Xiaofei" <xiaofei.wan at intel.com> wrote:

>Stefanus:
>
>Thanks for your suggestion, it is better to limit bufNamesStructTypesSet
>within llvm-link, this is what I planned to do at the beginning; I just
>worry about it will affect other component where ModuleLinker is used

"Strive for progress, not perfection". :)

If it's a problem for other components, they can fix it pretty easily,
especially once you add the optional parameter to ModuleLinker. We're
talking about roughly two lines of code in llvm-link (or other clients of
ModuleLinker) here.

On the flip side, it's just not reasonable to add something so specific to
Module. Module is used by _every_ LLVM client. Because of that, the bar is
very high to add something to it.

I'll be happy to review your updated patch.

Thanks,

Stefanus

--
Stefanus Du Toit <stefanus.du.toit at intel.com>
Intel Waterloo
Phone: 519-591-1738