[PATCH] Handle tied sub-operands in AsmMatcherEmitter

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Sat Apr 27 11:52:00 PDT 2013


Jim Grosbach <grosbach at apple.com> wrote on 27.04.2013 00:54:53:

> Sure. There’s a bit of a caveat that the original motivation for
> this patch originally intersects here. The first operand in the list
> isn’t necessarily the “real” one. We can probably fix this by using
> your suggestion above and consider whichever one of the two is used
> in the asm string as the real one. If both are used, make that an
> error and fix the strings that do that.

Right now, if both were actually used in the AsmString, they'd simply
be both emitted (independently) as operands, which is probably OK ...

> Oh drat. I always forget about the disassembler in this things.
> Sounds like we somewhat define away this issue w/ the above that
> removes the need for the new warning?

Yes, exactly.  With the new patch, the warning is gone anyway.

>> Do you agree with the approach in this updated patch?  If so, would
>> it be OK to commit as first step?   Thanks!
>
> Yep, this looks great!

Thanks, now committed as revision 180677.

Bye,
Ulrich




More information about the llvm-commits mailing list