[PATCH] New SystemZ backend: LLVM code changes

Eric Christopher echristo at gmail.com
Fri Apr 26 05:28:00 PDT 2013


On Fri, Apr 26, 2013 at 1:20 PM, Richard Sandiford
<rsandifo at linux.vnet.ibm.com> wrote:
> Rafael EspĂ­ndola <rafael.espindola at gmail.com> writes:
>>> Thanks for the pointer.  How does this look?  In case anyone's
>>> wondering, I didn't add an equivalent of DebugInfo/AArch64/cfi-frame.ll
>>> because .cfi_* directives are already tested in the CodeGen/SystemZ/frame-*.ll
>>> tests.
>>
>> Why -filetype=obj test? Please split these in two:
>>
>> * A .ll to .s test that checks that the expected .cfi_* directives are produced
>> * A .s to .o test that checks that .cfi_ directives are correctly assembled.
>
> Hmm, I was just trying to mimic the AArch64 tests, like Eric said. :-)
> Do you mean that there's something wrong with the way those work,
> or with the way I adapted them?

Heh. I was hoping for "any" but Rafael has a point. And I should have
mentioned that to the AArch64 guys as well.

-eric




More information about the llvm-commits mailing list