[PATCH] Add support to FileCheck for out-of-order matching

Jakob Stoklund Olesen stoklund at 2pi.dk
Wed Apr 24 15:01:37 PDT 2013


On Apr 24, 2013, at 2:44 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> ----- Original Message -----
>> From: "Jakob Stoklund Olesen" <stoklund at 2pi.dk>
>> To: "Michael Liao" <michael.liao at intel.com>
>> Cc: "Eli Bendersky" <eliben at google.com>, "Hal Finkel" <hfinkel at anl.gov>, "llvm-commits" <llvm-commits at cs.uiuc.edu>
>> Sent: Wednesday, April 24, 2013 4:25:02 PM
>> Subject: Re: [PATCH] Add support to FileCheck for out-of-order matching
>> 
>> 
>> On Apr 24, 2013, at 11:35 AM, Michael Liao <michael.liao at intel.com>
>> wrote:
>> 
>>> Is it valueable to mix CHECK-NOT and CHECK-DAG together?
>> 
>> Hal, do you have any use cases where it would be useful to mix
>> CHECK-DAG and CHECK-NOT?
> 
> Not currently; if I have CHECK-DAG then I can affirmatively check for the instructions that I expect (regardless of order), and I can't think of a case where I'd mix that with CHECK-NOT.

In that case, I think we should go with the simplest possible semantics when mixing CHECK-DAG and CHECK-NOT.

To me, that is having CHECK-NOT act as a barrier, just like CHECK does. CHECK-DAGs don't reorder across a CHECK-NOT.

Thanks,
/jakob




More information about the llvm-commits mailing list